use threading.Lock instead of mp.Lock #1972
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s should reduce overhead and avoid potential multiprocessing-related problems if user code also uses multiprocessing
|
can you give a description of what problem you are trying to solve and why this PR solves it? |
|
I've added a description of what problem you are trying to solve and why this PR solves it |
yorickvP
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1802 mentions
The use of multiprocessing.Lock was introduced in #1773. We suspected that this might have been interfering with other libraries that might use multiprocessing. The specific comfy error turned out to be caused by something else, but it's still unnecessary to have a multiprocess lock.